Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Replace util/pointer with util/ptr #2581

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Replace deprecated util/pointer with util/ptr + fix some lint issue

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f3c63f4) 64.47% compared to head (510550d) 64.39%.

Files Patch % Lines
controllers/vspherevm_controller.go 0.00% 1 Missing ⚠️
pkg/services/govmomi/vcenter/clone.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
- Coverage   64.47%   64.39%   -0.09%     
==========================================
  Files         118      118              
  Lines        8585     8585              
==========================================
- Hits         5535     5528       -7     
- Misses       2620     2625       +5     
- Partials      430      432       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srm09
Copy link
Contributor

srm09 commented Dec 29, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99d72c871fb0645b5e334e6e196762138421c630

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2023
@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5ba0691 into kubernetes-sigs:main Dec 29, 2023
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Dec 29, 2023
@fabriziopandini fabriziopandini deleted the replace-util-pointer branch January 8, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants